AlaskaAirlines / auro-checkbox

Custom element for the purpose of allowing users to select one or more options of a limited number of choices.
https://auro.alaskaair.com/components/auro/checkbox
Apache License 2.0
0 stars 1 forks source link

Move theming support from Beta to Main #137

Closed jordanjones243 closed 1 month ago

jordanjones243 commented 2 months ago

Alaska Airlines Pull Request

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Resolves: #128

Summary:

Please summarize the scope of the changes you have submitted, what the intent of the work is and anything that describes the before/after state of the project.

Type of change:

Please delete options that are not relevant.

Checklist:

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!
-- Auro Design System Team

Summary by Sourcery

Move theming support for the auro-checkbox component from beta to main, enabling customization through design tokens and updating documentation to reflect these changes.

New Features:

Enhancements:

Documentation:

CLAassistant commented 2 months ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

:white_check_mark: jordanjones243
:x: semantic-release-bot
You have signed the CLA already but the status is still pending? Let us recheck it.

sourcery-ai[bot] commented 2 months ago

Reviewer's Guide by Sourcery

This pull request moves theming support for the auro-checkbox component from Beta to Main. The changes primarily involve updating CSS styles to use new custom properties for theming, adding new SCSS files for color management, and updating documentation to reflect these changes. The implementation focuses on improving the component's flexibility for custom theming while maintaining its core functionality.

File-Level Changes

Files Changes
src/auro-checkbox.scss Removed hardcoded color values and replaced them with custom properties in the main SCSS file
src/color.scss
src/colorGroup.scss
src/tokens.scss
Added new SCSS files (color.scss, colorGroup.scss, tokens.scss) to manage theming and color-related styles
src/auro-checkbox.js
src/auro-checkbox-group.js
Updated the JavaScript files to import and use the new color and token styles
demo/api.md
docs/partials/api.md
Added documentation for theme support in the API markdown file
README.md Updated README.md to remove CSS custom property fallbacks section
CHANGELOG.md Updated CHANGELOG.md to reflect the new beta version with theming capabilities
eslint.config.mjs Added a new ESLint configuration file

Tips - Trigger a new Sourcery review by commenting `@sourcery-ai review` on the pull request. - Continue your discussion with Sourcery by replying directly to review comments. - You can change your review settings at any time by accessing your [dashboard](https://app.sourcery.ai): - Enable or disable the Sourcery-generated pull request summary or reviewer's guide; - Change the review language; - You can always [contact us](mailto:support@sourcery.ai) if you have any questions or feedback.
github-actions[bot] commented 1 month ago

Surge demo deployment failed! 😭

jordanjones243 commented 1 month ago

What is going on with the different background colors here?

Screenshot 2024-09-17 at 11 24 23 AM

Updated Figma doc:

Screen Shot 2024-09-17 at 11 42 18 AM