Closed jason-capsule42 closed 1 year ago
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.
:white_check_mark: jason-capsule42
:x: Jason Baker
The only bug I saw was in the "Disable individual checkboxes w/ required" example that we spoke about. Other than that, all of the other validity work looks good.
Turns out this was a documentation example issue rather that a code bug. This is cleaned up and review re-requested.
There is an inconsistency I am seeing with the error
attr. With other elements when the error
attr is added, validity="customError"
is added as well. Also, when error
is removed, validity="customError"
is removed also. That is not happening in the demo.
:tada: This PR is included in version 1.2.0 :tada:
The release is available on:
Your semantic-release bot :package::rocket:
Alaska Airlines Pull Request
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes: #68
Summary:
This PR adds HTML5 validation functionality to mirror functional changes made to other auro form element components.
Type of change:
Please delete options that are not relevant.
Checklist:
By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team