AlaskaAirlines / auro-combobox

An auroLabs custom element w/an experimental API. You've been warned.
https://auro.alaskaair.com/components/auroLabs
Apache License 2.0
4 stars 1 forks source link

Jbaker/error dropping fix #113

Closed jason-capsule42 closed 1 year ago

jason-capsule42 commented 1 year ago

Alaska Airlines Pull Request

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes: #111

Summary:

No longer removes the error attribute when menu reports a selection was made. The new validation method is the only code path that should be interacting here and the error attribute should never be removed programatically.

Type of change:

Please delete options that are not relevant.

Checklist:

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission! -- Auro Design System Team

blackfalcon commented 1 year ago

:tada: This PR is included in version 1.7.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: