search

AlaskaAirlines / auro-combobox

An auroLabs custom element w/an experimental API. You've been warned.
https://auro.alaskaair.com/components/auroLabs
Apache License 2.0
4 stars 1 forks source link

No matching option text not showing in bib #120

Closed jordanjones243 closed 2 weeks ago

jordanjones243 commented 1 year ago

Describe the bug

When there are no matching menu options after a user inputs text, an empty bib is shown, when there should be text saying "No matching option".

To Reproduce

Steps to reproduce the behavior:

  1. Go to https://auro.alaskaair.com/components/auro/combobox
  2. Navigate to the Basic example
  3. Type "M" into the input
  4. See error

Expected behavior

The dropdown should display the next "No matching option" when there are no matching menu options.

blackfalcon commented 1 year ago

@leeejune is there a design spec for this?

leeejune commented 1 year ago

@blackfalcon nope, no design specs.

blackfalcon commented 1 year ago

I created a new design story to look into this feature

jason-capsule42 commented 8 months ago

Changing from feature to bug as this API feature already exists, it just doesn't work and we might choose to style it differently in the future.

Patrick-Daly-AA commented 3 months ago

Putting in investigating to see if there is a slot for "no matching options" text (We suspect that there isn't one).

Next steps will be to create that slot and consult with design on having a potential for a default value.

Patrick-Daly-AA commented 2 months ago

Update: this is a bug. It needs fixing.