AlaskaAirlines / auro-combobox

An auroLabs custom element w/an experimental API. You've been warned.
https://auro.alaskaair.com/components/auroLabs
Apache License 2.0
4 stars 1 forks source link

Combobox's clear 'X' button is inset too far #121

Closed erikalanghauser closed 8 months ago

erikalanghauser commented 1 year ago

Describe the bug

When comparing the location of the X to clear the combobox field with other input elements, it is too far inset from the right. Does not match design specs and wastes input space.

To Reproduce

Steps to reproduce the behavior:

Hover over a combobox on auro doc site or at alaskaair.com/search.

Expected behavior

The location of the X should match datepicker and other input fields and be more symmetrical on left/right sides, matching design specs.

Screenshots

Not symmetrical/Wasted space on right side of field: image

image

Correct/Symmetrical: image

Desktop (please complete the following information):

Smartphone (please complete the following information):

Additional context

blackfalcon commented 1 year ago

This issue is validated. See the screen shot below, the additional spacing is caused by an incorrect CSS value.

Screen Shot 2023-02-22 at 4 21 01 PM
blackfalcon commented 1 year ago

Work specification

Remove the unnecessary right spacing.

Exit criteria

Validate that the padding is consistent with the design spec and that there are no unintended side-effects from removing this value.

jason-capsule42 commented 8 months ago

I have verified that this issue was previously fixed by updates to the auro-input component and how it's implemented into auro-combobox. Closing this issue as already fixed.