blackfalcon
commented
1 year ago Please update commit https://github.com/AlaskaAirlines/auro-combobox/pull/128/commits/a7bf2174e0edfdabee8b5531f0dfd8eae4354383 to have notes that this repo was updated to Lit2.0 as well as create the new feature.
Also commits https://github.com/AlaskaAirlines/auro-combobox/pull/128/commits/b8abdee6dfbdf79eb383e8d3a43e07814ae26953 and https://github.com/AlaskaAirlines/auro-combobox/pull/128/commits/4a130c80e0513d1b2858f24c9bf16833fa154448 can all be merged into the single https://github.com/AlaskaAirlines/auro-combobox/pull/128/commits/a7bf2174e0edfdabee8b5531f0dfd8eae4354383 commit. Those updates and a repeated feat(naming): improving dynamic naming of deps message has no real long-term historical value.
jason-capsule42
Alaska Airlines Pull Request
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes: #127
Summary:
This work shows using a dynamically generated hash to create a unique element name used during the custom element definition
Type of change:
Please delete options that are not relevant.
Checklist:
By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team