AlaskaAirlines / auro-combobox

An auroLabs custom element w/an experimental API. You've been warned.
https://auro.alaskaair.com/components/auroLabs
Apache License 2.0
4 stars 1 forks source link

Refactor the initialization of examples #141

Closed jordanjones243 closed 1 year ago

jordanjones243 commented 1 year ago

Alaska Airlines Pull Request

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes: #140

Summary:

Please summarize the scope of the changes you have submitted, what the intent of the work is and anything that describes the before/after state of the project.

Refactor the initialization of the examples by exporting every example as a function and having a main parent function run all of the examples when the respective demo pages are loaded.

Type of change:

Please delete options that are not relevant.

Checklist:

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!
-- Auro Design System Team

jordanjones243 commented 1 year ago

Note for reviewer:

A setTimeout function is used in the index.js andapi.js files for the examples due to a runtime issue where the calls to locate the html from the javascript files were receiving null values.

blackfalcon commented 1 year ago

:tada: This PR is included in version 1.7.5 :tada:

The release is available on:

Your semantic-release bot :package::rocket: