AlaskaAirlines / auro-combobox

An auroLabs custom element w/an experimental API. You've been warned.
https://auro.alaskaair.com/components/auroLabs
Apache License 2.0
4 stars 1 forks source link

feat(deps): dynamic renaming of dependency elements with version #127 #148

Closed jason-capsule42 closed 1 year ago

jason-capsule42 commented 1 year ago

Alaska Airlines Pull Request

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes: #127

Summary:

Please summarize the scope of the changes you have submitted, what the intent of the work is and anything that describes the before/after state of the project.

Type of change:

Please delete options that are not relevant.

Checklist:

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!
-- Auro Design System Team

jason-capsule42 commented 1 year ago

Moved back to Work in Progress - import Auro-Library once it's a package and call scripts from there.

https://github.com/AlaskaAirlines/auro-library/issues/13

blackfalcon commented 1 year ago

Moving this update to DRAFT PR since it has a new dependency on Auro Library. Also, the feature branch is out of date with the main branch. Please rebase.

Izook commented 1 year ago

All code changes look good, but the javascript examples are not working on the demo

Not sure if related but I'm seeing this error in the console when I run the dynamic menu api demo: image

Otherwise changes look good

jason-capsule42 commented 1 year ago

All code changes look good, but the javascript examples are not working on the demo

Not sure if related but I'm seeing this error in the console when I run the dynamic menu api demo: image

Otherwise changes look good

@Izook This was definitely related. Great catch! doc example updated to work with dynamic tags.

blackfalcon commented 1 year ago

:tada: This PR is included in version 1.8.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: