AlaskaAirlines / auro-combobox

An auroLabs custom element w/an experimental API. You've been warned.
https://auro.alaskaair.com/components/auroLabs
Apache License 2.0
4 stars 1 forks source link

Update CSS token per new design system theming capability #154

Closed fajar-apri-alaska closed 9 months ago

fajar-apri-alaska commented 10 months ago

Alaska Airlines Pull Request

Fixes: #153

Summary:

Type of change:

Please delete options that are not relevant.

Checklist:

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!
-- Auro Design System Team

fajar-apri-alaska commented 10 months ago

The npm ci is failing because some auro components have conflicting peer dependency for @aurodesignsystem/webcorestylesheets package. Should I hold of this until those components are updated?

fajar-apri-alaska commented 10 months ago

Please be sure to update all package dependencies and update repo to support our Node support policy https://auro.alaskaair.com/node-support#gsc.tab=0

Does this means that we will need to work on changes based on node 18 updates for this component also? Sure, I could do that in a new issue ticket.

Edit: Oh this component have already updated to node 18, my bad. All I need to do is to update the node engines to below value right?

"engines": {
  "node": "^18 || ^20"
}
blackfalcon commented 9 months ago

:tada: This PR is included in version 1.8.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: