AlaskaAirlines / auro-combobox

An auroLabs custom element w/an experimental API. You've been warned.
https://auro.alaskaair.com/components/auroLabs
Apache License 2.0
4 stars 1 forks source link

Beta tech debt #188

Closed jordanjones243 closed 1 month ago

jordanjones243 commented 1 month ago

Alaska Airlines Pull Request

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Resolves: # (issue, if applicable)

Summary:

Please summarize the scope of the changes you have submitted, what the intent of the work is and anything that describes the before/after state of the project.

Type of change:

Please delete options that are not relevant.

Checklist:

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!
-- Auro Design System Team

Summary by Sourcery

Refactor the component registration process to utilize RuntimeUtils for defining custom elements, update related documentation, and refresh stylesheet links in the README to newer versions.

Enhancements:

Documentation:

Chores:

sourcery-ai[bot] commented 1 month ago

Reviewer's Guide by Sourcery

This pull request implements several changes to modernize and improve the codebase, primarily focusing on updating the component registration process and dependency versions. The changes aim to enhance the maintainability and consistency of the project.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Refactored component registration process
  • Removed custom registerComponent function
  • Imported RuntimeUtils from auro-library
  • Used RuntimeUtils.default.prototype.registerComponent for component registration
index.js
demo/index.html
demo/index.md
docs/partials/index.md
Updated dependency versions
  • Updated design-tokens version to 4.9.2
  • Updated webcorestylesheets version to 5.1.2
README.md
Fixed component tag name in runtime utils call
  • Changed 'auro-datepicker' to 'auro-combobox' in handleComponentTagRename call
src/auro-combobox.js
Removed version information from specific files
  • Deleted content of src/dropdownVersion.js
  • Deleted content of src/inputVersion.js
src/dropdownVersion.js
src/inputVersion.js

Tips and commands #### Interacting with Sourcery - **Trigger a new review:** Comment `@sourcery-ai review` on the pull request. - **Continue discussions:** Reply directly to Sourcery's review comments. - **Generate a GitHub issue from a review comment:** Ask Sourcery to create an issue from a review comment by replying to it. #### Customizing Your Experience Access your [dashboard](https://app.sourcery.ai) to: - Enable or disable review features such as the Sourcery-generated pull request summary, the reviewer's guide, and others. - Change the review language. - Add, remove or edit custom review instructions. - Adjust other review settings. #### Getting Help - [Contact our support team](mailto:support@sourcery.ai) for questions or feedback. - Visit our [documentation](https://docs.sourcery.ai) for detailed guides and information. - Keep in touch with the Sourcery team by following us on [X/Twitter](https://x.com/SourceryAI), [LinkedIn](https://www.linkedin.com/company/sourcery-ai/) or [GitHub](https://github.com/sourcery-ai).
blackfalcon commented 1 month ago

:tada: This PR is included in version 2.0.0-beta.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: