Closed jason-capsule42 closed 2 weeks ago
This PR fixes the handling of the 'no match' option in the auro-combobox component. The changes improve the state management of the noMatchOption and modify the visibility logic for options based on static attributes.
classDiagram
class AuroCombobox {
+List availableOptions
+String input
+Dropdown dropdown
+Option noMatchOption
+showBib()
}
class Option {
+String innerText
+Boolean hasAttribute(String)
+void removeAttribute(String)
+void setAttribute(String, String)
+String getAttribute(String)
}
class Dropdown {
+Boolean isPopoverVisible
+void show()
}
AuroCombobox --> Option
AuroCombobox --> Dropdown
note for AuroCombobox "Improved state management for noMatchOption and modified visibility logic for options."
Change | Details | Files |
---|---|---|
Refactored noMatchOption handling to use class property instead of local variable |
|
src/auro-combobox.js |
Modified option filtering logic to exclude static options |
|
src/auro-combobox.js |
Updated dropdown visibility logic to consider noMatchOption |
|
src/auro-combobox.js |
:tada: This PR is included in version 2.1.4 :tada:
The release is available on:
Your semantic-release bot :package::rocket:
Alaska Airlines Pull Request
Type of change:
Please delete options that are not relevant.
Checklist:
By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team
Summary by Sourcery
Fix the handling of 'no match' options in the AuroCombobox component and improve the logic for displaying available options. Add a settings.json file to configure the development environment.
Bug Fixes:
Enhancements:
Build: