search

AlaskaAirlines / auro-drawer

Custom element that displays additional information over page content
https://auro.alaskaair.com/components/auro/drawer
Apache License 2.0
0 stars 0 forks source link

Drawer does not scroll when content spans past screen height #17

Closed arrenleung closed 5 months ago

arrenleung commented 7 months ago

Please verify the version of auro-drawer you have installed

1.0.8

Please describe the bug

  1. Create an auro-drawer component with content that spans past the screen height (or height of the drawer)
  2. Open the drawer
  3. See that you are unable to scroll within the drawer to see the content past the screen
image

Reproducing the error

This issue is reproducible on the Auro docsite

Expected behavior

When drawer content spans longer than the screen height (or drawer's max height), the drawer becomes scrollable.

What browsers are you seeing the problem on?

Firefox, Chrome, Safari

Additional context

The bug is not reproducible on the deprecated auro-interruption drawer component.

I opened a similar bug in the auro-dialog component as well.

Exit criteria

When drawer content spans longer than the screen height (or drawer's max height), the drawer becomes scrollable.

Patrick-Daly-AA commented 7 months ago

Same fix needed here as was applied here: https://github.com/AlaskaAirlines/auro-dialog/issues/15

Will retest and implement fix.

Patrick-Daly-AA commented 6 months ago

Issue still occurs after the related issues is fixed. more investigation is needed.

gusnaughton commented 5 months ago

Issue is still occuring with the latest version 1.0.8. @Patrick-Daly-AA is there an estimated fix on this? I have also tested and 1.0.0 of @aurodesignsystem/auro-drawer has this issue.

gusnaughton commented 5 months ago

https://github.com/AlaskaAirlines/auro-drawer/assets/7005799/e25f2989-494a-4da9-b4bc-7b25800843d8

This is particularily impactful on seat map use cases

jordanjones243 commented 5 months ago

:tada: This issue has been resolved in version 1.0.9 :tada:

The release is available on:

Your semantic-release bot :package::rocket: