AlaskaAirlines / auro-flightline

A custom element that represents the intermediate details between a departure and arrival station on a flight.
https://auro.alaskaair.com/components/auro/flightline
Apache License 2.0
0 stars 2 forks source link

Fix summary segment overflow #33

Closed geoffrich closed 2 years ago

geoffrich commented 2 years ago

Alaska Airlines Pull Request

Fixes #32

Summary:

Fixes the flightline overflowing when showing a summary segment. This was because the :first-child selector used to shorten the first segment in a flightline did not apply to the summary segment, which was the second child (after the slot).

Also remove references to the Sass demo build, which caused npm run dev to fail.

Type of change:

Please delete options that are not relevant.

Checklist:

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!
-- Auro Design System Team

blackfalcon commented 2 years ago

Verified fix

Screen Shot 2022-01-27 at 9 44 03 AM
blackfalcon commented 2 years ago

:tada: This PR is included in version 1.3.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: