search

AlaskaAirlines / auro-header

Custom content header element
https://auro.alaskaair.com/components/auro/header
Apache License 2.0
0 stars 2 forks source link

Add tag name as attribute #124

Closed jordanjones243 closed 1 month ago

jordanjones243 commented 1 month ago

Alaska Airlines Pull Request

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Resolves: #123

Summary:

Please summarize the scope of the changes you have submitted, what the intent of the work is and anything that describes the before/after state of the project.

Type of change:

Please delete options that are not relevant.

Checklist:

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!
-- Auro Design System Team

Summary by Sourcery

Introduce a new feature that allows the component's tag name to be set as an attribute, enhancing the component's flexibility in usage.

New Features:

sourcery-ai[bot] commented 1 month ago

Reviewer's Guide by Sourcery

This pull request adds functionality to the AuroHeader component to include the tag name as an attribute when it differs from the component name. It introduces a new utility class and implements a lifecycle method to handle this functionality.

File-Level Changes

Change Details Files
Introduce AuroLibraryRuntimeUtils for component tag renaming
  • Import and instantiate AuroLibraryRuntimeUtils in the constructor
  • Add a private property 'runtimeUtils' to store the instance
 src/auro-header.js
Implement firstUpdated lifecycle method for tag renaming
  • Add firstUpdated method to the component
  • Call handleComponentTagRename method from runtimeUtils
  • Pass 'this' and 'auro-header' as arguments to handleComponentTagRename
 src/auro-header.js
Tips - Trigger a new Sourcery review by commenting `@sourcery-ai review` on the pull request. - Continue your discussion with Sourcery by replying directly to review comments. - You can change your review settings at any time by accessing your [dashboard](https://app.sourcery.ai): - Enable or disable the Sourcery-generated pull request summary or reviewer's guide; - Change the review language; - You can always [contact us](mailto:support@sourcery.ai) if you have any questions or feedback.
blackfalcon commented 1 month ago

:tada: This PR is included in version 2.3.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: