AlaskaAirlines / auro-hyperlink

Custom hyperlink element to connect webpages or data items to one another
https://auro.alaskaair.com/components/auro/hyperlink
Apache License 2.0
2 stars 2 forks source link

Bundled version of hyperlink is not working as expected #161

Closed blackfalcon closed 1 year ago

blackfalcon commented 1 year ago

Describe the bug

Reviewing the latest release of auro-hypelrink v3.3.1 on the Auro docsite it was discovered that the bundled version is not operating as expected.

Verify the version of @aurodesignsystem/auro-hyperlink you have installed

The current version is: See it on NPM!

My project has @aurodesignsystem/auro-hyperlink v3.3.1 installed

To Reproduce

Steps to reproduce the behavior:

  1. Go to https://auro.alaskaair.com/components/auro/hyperlink
  2. See error

Are you able to reproduce this issue on the Auro doc site?

Expected behavior

The hyperlink component should work as expected when using the bundled version.

Screenshots

Screen Shot 2023-02-27 at 9 33 06 AM

Additional context

blackfalcon commented 1 year ago

Doing some digging it was discovered that the issue here is with our new process of importing the element js into the scope of the index.js file. See this link from Rollup docs

https://rollupjs.org/troubleshooting/#warning-treating-module-as-external-dependency

This issue would have been difficult to realize in any local testing. The error in the CLI is easily missed and even if you were testing the bundled version, the error resulted in NOT creating a new bundled version and the old version is still in the dist directory.

I am advocating for a process update in the build script that will use the sweep command prior to a new build. This will ensure that legacy assets are not left around prior to a new build thus directly exposing new issues.