Closed irma-kurnia-alaska closed 1 year ago
Hi @blackfalcon,
I will updated as your feedback. Thank you.
@irma-kurnia-alaska Please delete the package-lock.json file and the node_packages dir and then re-install all node packages to build out a clean package-lock.json file with the current version of npm with node 18.
Hi @blackfalcon,
I will update the PR as your feedback, please review this, thank you.
Ok @Dale @.***>, i will update. Thank you
Dapatkan Outlook untuk Androidhttps://aka.ms/AAb9ysg
From: Dale Sande @.> Sent: Tuesday, June 6, 2023 6:12:27 AM To: AlaskaAirlines/auro-hyperlink @.> Cc: Irma Kurnia @.>; Mention @.> Subject: Re: [AlaskaAirlines/auro-hyperlink] Irmaku/update node18 (PR #170)
[EXTERNAL SENDER]
@blackfalcon requested changes on this pull request.
In .github/ISSUE_TEMPLATE/bug_report.ymlhttps://github.com/AlaskaAirlines/auro-hyperlink/pull/170#discussion_r1218688232:
@@ -0,0 +1,60 @@ +name: Feature request
Wrong name
— Reply to this email directly, view it on GitHubhttps://github.com/AlaskaAirlines/auro-hyperlink/pull/170#pullrequestreview-1463727479, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A5XE7PRIBVEC7LEGV46ZZSDXJZRVXANCNFSM6AAAAAAXZVHTSI. You are receiving this because you were mentioned.Message ID: @.***>
Hi @blackfalcon,
i will fix this for the issue ERROR: ./demo/apiExamples.md file is missing. Sorry for this. When I checked the apiExamples is hidden in my machine and i will fix this. thank you.
:tada: This PR is included in version 3.3.4 :tada:
The release is available on:
Your semantic-release bot :package::rocket:
Alaska Airlines Pull Request
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Resolves: #166 , #167 , #168 , #169 , #171
Summary:
Please summarize the scope of the changes you have submitted, what the intent of the work is and anything that describes the before/after state of the project.
Type of change:
Checklist:
By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team