introduce `span` with css part around slot when no href is present - Githubissues

AlaskaAirlines / auro-hyperlink

Custom hyperlink element to connect webpages or data items to one another

https://auro.alaskaair.com/components/auro/hyperlink

Apache License 2.0

2 stars 2 forks source link

introduce `span` with css part around slot when no href is present #175

Closed Izook closed 1 year ago

Izook commented 1 year ago

Is your feature request related to a problem? Please describe.

when customizing hyperlinks it is difficult to get consistent styling between cases when the href is and isn't present

Describe the solution you'd like

provide a span when href isn't present to provide something to style

Describe alternatives you've considered

overriding the render function of hyperlink to add a span around the slotted content when the hyperlink isnt present

Additional context

Verify the version of @aurodesignsystem/auro-hyperlink you have installed

The current version is:

My project has @aurodesignsystem/auro-hyperlink v3.3.3 installed

blackfalcon commented 1 year ago

The styling of a hyperlink NOT looking like a link when the href is not present is intentional. Adding a CSS part to override this would negate the deliberate feature of the component.