AlaskaAirlines / auro-hyperlink

Custom hyperlink element to connect webpages or data items to one another
https://auro.alaskaair.com/components/auro/hyperlink
Apache License 2.0
2 stars 2 forks source link

The bundled CSS includes all design tokens #178

Closed blackfalcon closed 11 months ago

blackfalcon commented 11 months ago

Please verify the version of auro-hyperlink you have installed

3.3.4

Please describe the bug

When reviewing the recently updated it was noticed that the design tokens are still being added to the element's style.css

https://github.com/AlaskaAirlines/auro-hyperlink/blob/243317035411f6394a5c5f0ab5beeb53ad2727d3/src/style.scss#L8

This is not necessary. The tokens are installed at the APP lever. This code should have been removed with recent updates that removed support for IE11 and other legacy browsers that did not support CSS custom properties. Use the following link to see all the tokens added to the css-js file in the latest release.

https://www.runpkg.com/?@aurodesignsystem/auro-hyperlink@3.3.4/src/style-css.js

Reproducing the error

This issue is reproducible on the Auro docsite

Expected behavior

Remove the reference to the design tokens in the element's code and remove the tokens from the output css-js file for the element's rendering.

What browsers are you seeing the problem on?

Firefox, Chrome, Safari, Microsoft Edge

Exit criteria

This issue can be closed once the Auro design tokens are no longer part of the element's final npm bundle.