AlaskaAirlines / auro-hyperlink

Custom hyperlink element to connect webpages or data items to one another
https://auro.alaskaair.com/components/auro/hyperlink
Apache License 2.0
2 stars 3 forks source link

Update small CTA to adjust content alignment #192

Closed blackfalcon closed 10 months ago

blackfalcon commented 10 months ago

Alaska Airlines Pull Request

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes: #191

Summary:

Please summarize the scope of the changes you have submitted, what the intent of the work is and anything that describes the before/after state of the project.

There was mainly an issue with the placement of an icon within the small CTA use case. The update allows for easier management of the additional content.

A couple of stylelint rules were slightly adjusted to allow for new code without having to also do a code refactor to meet linting needs.

Changes to be committed: modified: .stylelintrc modified: src/style.scss

Before

Screen Shot 2024-01-06 at 2 23 34 PM

After

Screen Shot 2024-01-06 at 3 37 36 PM

Type of change:

Please delete options that are not relevant.

Checklist:

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!
-- Auro Design System Team

blackfalcon commented 10 months ago

@jason-capsule42, @leeejune completed a design review and approved. Reaching out to complete a code review.

Thanks!

blackfalcon commented 10 months ago

:tada: This PR is included in version 3.4.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket: