search

AlaskaAirlines / auro-hyperlink

Custom hyperlink element to connect webpages or data items to one another
https://auro.alaskaair.com/components/auro/hyperlink
Apache License 2.0
2 stars 2 forks source link

Implement minified js system #199

Closed jordanjones243 closed 7 months ago

jordanjones243 commented 8 months ago

Alaska Airlines Pull Request

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Resolves: #198

Summary:

Please summarize the scope of the changes you have submitted, what the intent of the work is and anything that describes the before/after state of the project.

Implement current minified js system that runs the js for examples on the demo files.

Type of change:

Please delete options that are not relevant.

Checklist:

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!
-- Auro Design System Team

jordanjones243 commented 7 months ago

This PR is currently sitting in draft mode because the focus example is not working as intended.

jordanjones243 commented 7 months ago

Take note: the programmatic focus example was removed from the repo. Adding focus programmatically does not give the same UX as when a user applys focus to a hyperlink via tabbing.

jordanjones243 commented 7 months ago

Take note: the programmatic focus example was removed from the repo. Adding focus programmatically does not give the same UX as when a user applys focus to a hyperlink via tabbing.

I can confirm that this example does not work on the localhost in main, nor on the docsite

blackfalcon commented 7 months ago

:tada: This PR is included in version 3.5.7 :tada:

The release is available on:

Your semantic-release bot :package::rocket: