search

AlaskaAirlines / auro-hyperlink

Custom hyperlink element to connect webpages or data items to one another
https://auro.alaskaair.com/components/auro/hyperlink
Apache License 2.0
2 stars 3 forks source link

[Feature]: New 'tertiary' variant #205

Closed fajar-apri-alaska closed 6 months ago

fajar-apri-alaska commented 7 months ago

Alaska Airlines Pull Request

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Resolves: #204

Summary:

This PR is to provides 'tertiary' option for CTA-hyperlink per ticket #204.

Type of change:

Please delete options that are not relevant.

Checklist:

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!
-- Auro Design System Team

fajar-apri-alaska commented 7 months ago

Hi team, News are, the key token values are a bit different with the one from blueprints (still using --auro instead of --ds). I tried to map out per the latest ones. But I'm still not sure since some value are a bit off by it looks after it is rendered on the browser. So if anything is a miss from my side, please tell me so. Thanks.

Figma/Blueprint links: https://github.com/AlaskaAirlines/auro-hyperlink/issues/204#issuecomment-2061749224

blackfalcon commented 7 months ago

Hi team, News are, the key token values are a bit different with the one from blueprints (still using --auro instead of --ds). I tried to map out per the latest ones. But I'm still not sure since some value are a bit off by it looks after it is rendered on the browser. So if anything is a miss from my side, please tell me so. Thanks.

Figma/Blueprint links: #204 (comment)

@leeejune please take note that the Figma blueprint is still referencing --auro- versus --ds.

blackfalcon commented 6 months ago

:tada: This PR is included in version 3.6.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: