AlaskaAirlines / auro-hyperlink

Custom hyperlink element to connect webpages or data items to one another
https://auro.alaskaair.com/components/auro/hyperlink
Apache License 2.0
2 stars 2 forks source link

Combination of attributes may be causing JS error #206

Open blackfalcon opened 1 month ago

blackfalcon commented 1 month ago

Please verify the version of auro-hyperlink you have installed

@latest

Please describe the bug

Content containing an auro-hyperlink with both the relative and target="_blank" attributes caused an error on the page.

Reproducing the error

This issue cannot be reproduced on the Auro docsite

Expected behavior

It is assumed that using both attributes should not cause an error.

What browsers are you seeing the problem on?

Firefox, Chrome, Safari, Microsoft Edge

Additional context

See this commit:

https://github.com/AlaskaAirlines/AuroDocsSite/pull/222/commits/e9ce9e6668b5d54d8542b98d8af371cb8d5b4bbb

These updates modify the auro-hyperlink target attribute references to resolve an issue on the home and Support pages where the UI was unresponsive on render.

This issue may be a bug with auro-hyperlink when relative and target are used on the same anchor tag.

While updating the Auro Doc Site, an issue was discovered on the Home and Support pages where the left navigation scrolling and all links were unusable.

Both pages contain FAQ content. In the question "Q: Does Auro support React, Svelte, Vue, etc.?" there were two links that contained both the relative and target="_blank" attributes. It was discovered that removing the target="_blank" attribute resolved the issue.

It is currently undetermined if this issue appears in the Lit element development environment, as there is no current demo of this use, or if it is specific to the auro-hyperlink and the doc site.

Exit criteria

This issue can be closed once it is determined whether the bug is with the element itself or specific to the Auro doc site. Once identified, appropriate actions will be taken to address the issue.