AlaskaAirlines / auro-hyperlink

Custom hyperlink element to connect webpages or data items to one another
https://auro.alaskaair.com/components/auro/hyperlink
Apache License 2.0
2 stars 3 forks source link

fix: adjust shape of UI for a11y UI 209 #210

Closed blackfalcon closed 4 months ago

blackfalcon commented 4 months ago

Alaska Airlines Pull Request

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Resolves: #209

Summary:

The issue around the misshaped UI was related to the manual nudging of the inserted icon and the updates to the icons shape and relative size over time.

Updating the nudge from 2px to 4px addresses the UI issue.

This commit also has an update to the README based on updates to the generator with the build process.

On branch dsande/focusVisible/209 Changes to be committed: modified: README.md modified: src/style.scss

BEFORE

Screenshot 2024-07-10 at 10 41 02 AM

AFTER

Screenshot 2024-07-10 at 10 46 39 AM

Type of change:

Please delete options that are not relevant.

Checklist:

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!
-- Auro Design System Team

blackfalcon commented 4 months ago

:tada: This PR is included in version 3.6.1-beta.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: