AlaskaAirlines / auro-hyperlink

Custom hyperlink element to connect webpages or data items to one another
https://auro.alaskaair.com/components/auro/hyperlink
Apache License 2.0
2 stars 3 forks source link

Move theming support from Beta to Main #216

Closed jordanjones243 closed 1 month ago

jordanjones243 commented 3 months ago

Alaska Airlines Pull Request

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Resolves: #177, #211

Summary:

Please summarize the scope of the changes you have submitted, what the intent of the work is and anything that describes the before/after state of the project.

Type of change:

Please delete options that are not relevant.

Checklist:

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!
-- Auro Design System Team

Summary by Sourcery

Move theming support from Beta to Main by introducing CSS variable-based theming for the auro-hyperlink component, adding support for 'ondark' mode, and refactoring for performance improvements. Update documentation and tests to align with these changes.

New Features:

Enhancements:

Documentation:

Tests:

CLAassistant commented 3 months ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
3 out of 4 committers have signed the CLA.

:white_check_mark: blackfalcon
:white_check_mark: jordanjones243
:white_check_mark: jason-capsule42
:x: semantic-release-bot
You have signed the CLA already but the status is still pending? Let us recheck it.

sourcery-ai[bot] commented 3 months ago

Reviewer's Guide by Sourcery

This pull request implements theming support for the auro-hyperlink component. The changes include adding new CSS custom properties for various states and types of hyperlinks, implementing color variants for different modes (default and inverse), and updating the component to use these new styles. The PR also adds support for ondark variants of existing examples and introduces new files for handling color styles and icon versioning.

File-Level Changes

Files Changes
src/tokens.scss Added new CSS custom properties for various hyperlink states and types
src/color.scss Implemented color variants for different modes (default and inverse) and hyperlink types
src/auro-hyperlink.js
src/style.scss
Updated component to use new theming styles
demo/api.md
demo/index.md
apiExamples/basic-ondark.html
apiExamples/cta-ondark.html
apiExamples/external-ondark.html
apiExamples/external-referrer-ondark.html
apiExamples/navPattern-ondark.html
apiExamples/navStyle-ondark.html
apiExamples/roleButton-ondark.html
Added ondark variants for existing examples
src/iconVersion.js
src/auro-hyperlink.js
Introduced icon versioning support
README.md
docs/partials/index.md
docs/partials/api.md
Updated documentation to reflect new theming capabilities
src/component-base.mjs Refactored some variable names for consistency
eslint.config.mjs Updated ESLint configuration

Tips - Trigger a new Sourcery review by commenting `@sourcery-ai review` on the pull request. - Continue your discussion with Sourcery by replying directly to review comments. - You can change your review settings at any time by accessing your [dashboard](https://app.sourcery.ai): - Enable or disable the Sourcery-generated pull request summary or reviewer's guide; - Change the review language; - You can always [contact us](mailto:support@sourcery.ai) if you have any questions or feedback.
blackfalcon commented 1 month ago

:tada: This PR is included in version 4.0.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: