AlaskaAirlines / auro-hyperlink

Custom hyperlink element to connect webpages or data items to one another
https://auro.alaskaair.com/components/auro/hyperlink
Apache License 2.0
2 stars 3 forks source link

Create blueprint figma file #77

Closed braven112 closed 2 years ago

braven112 commented 3 years ago

General Support Request

Create a blueprint for hyperlink and all the variants.

Your Environment

blackfalcon commented 3 years ago

Current blueprint https://www.figma.com/file/TSFOFDwWQxmpPpYQ2F06lH/Hyperlink?node-id=322%3A298 from https://github.com/AlaskaAirlines/auro-button/issues/134

This is under review. @leeejune please find some time where we can talk about this together.

leeejune commented 3 years ago

Blueprint edited and completed. @blackfalcon Please review.

blackfalcon commented 3 years ago

Sorry, this was a little confusing. I think I can update the Figma file. I will take a stab at it.

leeejune commented 3 years ago

I'd love to help clarify! Are there any specific parts that are confusing?

blackfalcon commented 3 years ago

No worries... the confusing part was from me. The strings to be included as defaults aren't very clear from my instructions. I need to update the actual spec. It's my bad.

leeejune commented 3 years ago

Got it! Please let me know if I should make edits after you edit the specs!

blackfalcon commented 3 years ago

This is not correct

Screen Shot 2021-11-01 at 8 04 17 PM

This is a hacked example from the doc site

Screen Shot 2021-11-01 at 8 10 22 PM
blackfalcon commented 3 years ago

Tertiary CTA is not supported, should not be in the Figma doc

Screen Shot 2021-11-01 at 8 11 59 PM
blackfalcon commented 3 years ago

@leeejune please see two previous comments.

leeejune commented 3 years ago

Got it! Edits made to blueprint:

blackfalcon commented 3 years ago

@leeejune this looks good. Let's get the PR going for the Design .md file with the Figma frame and release notes.

leeejune commented 3 years ago

Will do! It is confirmed to publish on Figma as well?