search

AlaskaAirlines / auro-icon

Custom HTML element for the use of easily displaying an icon from the Auro Icon library
https://auro.alaskaair.com/components/auro/icon
Apache License 2.0
0 stars 4 forks source link

auro-icon still using tier 1 tokens #146

Open jordanjones243 opened 3 weeks ago

jordanjones243 commented 3 weeks ago

Please verify the version of auro-icon you have installed

5.0.2

Please describe the bug

  1. Go to https://github.com/AlaskaAirlines/auro-icon/blob/master/src/style.scss
  2. See error on line 24 (--ds-color-brand-midnight-400)
  3. Go to https://github.com/AlaskaAirlines/auro-icon/blob/master/src/alaskaStyle.scss
  4. See error on line 26 (--ds-color-base-white)

Reproducing the error on the docsite

This issue cannot be reproduced on the Auro docsite

Expected behavior

Tier 3 semantic tokens should be created as aliases for these tokens

What browsers are you seeing the problem on?

No response

Additional context

Tier 3 semantic tokens should be used within every component in Auro

Exit criteria

Tier 3 semantic tokens should are created as aliases for these tokens

jason-capsule42 commented 3 weeks ago

Note that both of these colors are for the Alaska Logo. Does that mean they should remain as tier 1?

Patrick-Daly-AA commented 3 weeks ago

Question for @leeejune , do we foresee ever needing/wanting to make the colors in the logo theme-able? Should be just add some Tier 2 "brand only" color tokens?