search

AlaskaAirlines / auro-icon

Custom HTML element for the use of easily displaying an icon from the Auro Icon library
https://auro.alaskaair.com/components/auro/icon
Apache License 2.0
0 stars 4 forks source link

auro-icon: Resize Icon When Label Exists #89

Open rallyb13 opened 1 year ago

rallyb13 commented 1 year ago

Is your feature request related to a problem? Please describe.

The customSize attribute works great to resize, but only when there's no label. Because it targets the parent element rather than the icon itself, any resize attempt ends up targeting the label as well. Which means that a) the icon itself does not resize & b) the label text has CSS applied that I don't want.

Screenshot 2023-06-15 at 10 40 18 AM

Describe the solution you'd like

The ability to target the icon only while also using a label.

Describe alternatives you've considered

When used transform: scale, which only works because we conveniently wanted the font-size to differ by the same proportion.

Additional context

No response

blackfalcon commented 1 year ago

@rallyb13 you are correct. The ability to resize never considered its association with the label content.

@Patrick-Daly-AA This is a viable feature we should add to this element. @rallyb13 do you have availability to contribute to this update?

Patrick-Daly-AA commented 1 year ago

Assigning to @leeejune for input on if this is compliant with our design, or if the design needs to be updated to accommodate this.

rallyb13 commented 1 year ago

@rallyb13 do you have availability to contribute to this update? Not in the immediate future, I'm afraid. If it still hasn't been picked up after the hackathon, then maybe...?