search

AlaskaAirlines / auro-input

Custom HTML element for inputting string data in forms
https://auro.alaskaair.com/components/auro/input
Apache License 2.0
2 stars 4 forks source link

'auroInput-validated' event defined in docs but doesn't ever get fired. #233

Closed jason-capsule42 closed 1 year ago

jason-capsule42 commented 1 year ago

Describe the bug

To Reproduce

Steps to reproduce the behavior:

  1. Go to the required example
  2. Give the input focus
  3. blue from the focus
  4. See error

Expected behavior

The correct required validity state is applied to the auro-input but the auroInput-validated event is never fired.

blackfalcon commented 1 year ago

This issue was caused due to the removal of code in this PR.

https://github.com/AlaskaAirlines/auro-input/commit/6ec40c3f3aaf1b04e101f26da078b1546357b757#diff-aedef65e662f6f161de4dda6e34b704053e1778b73199c5d58273e4d66c7f4fbL483-L488

This PR was part of a major refactor of the related functionality. I feel that the miss was attributed to a missing test. We will want to look into how this feature was missed in the refactor and augment the testing scenario to ensure that this is not a problem in the future.