search

AlaskaAirlines / auro-input

Custom HTML element for inputting string data in forms
https://auro.alaskaair.com/components/auro/input
Apache License 2.0
2 stars 4 forks source link

Show Password button not displaying in Examples, and doesn't display locally #287

Closed zmoore-alaskaair closed 6 months ago

zmoore-alaskaair commented 7 months ago

Please verify the version of auro-input you have installed

2.17.0

Please describe the bug

example not showing button not displaying when there's an error either

Reproducing the error on the docsite

This issue is reproducible on the Auro docsite

Expected behavior

There should be an eye icon that toggles between filled and unfilled, open and crossed, when there is content within the password field.

It looks like there's a previous issue where the problem was resolved, so this may be a regression since then.

What browsers are you seeing the problem on?

Firefox, Chrome, Microsoft Edge

Additional context

No response

Patrick-Daly-AA commented 7 months ago

Currently investigating. If an urgent workaround is needed, recommend rolling back a version.

braven112 commented 6 months ago

Still investigating but it appears we aren't triggering this class name .passwordIcon--show on the password icon

braven112 commented 6 months ago

Looks like we removed the necessary class as part of fixing #268

braven112 commented 6 months ago

Notes for Monday: We have a branch to simplify the logic but it still needs some CSS and UX changes. When 2 Icons are showing the padding on the right needs to be 4rem When 3 Icons are showing the the padding on the right needs to be 6rem The UX for the eye and when it shows should likely be the same as the X button The eye icon and X button should show up as soon as there is text in the input.