search

AlaskaAirlines / auro-input

Custom HTML element for inputting string data in forms
https://auro.alaskaair.com/components/auro/input
Apache License 2.0
2 stars 4 forks source link

clear btn is enabled when auro-input is disabled and has a value #309

Closed cynthiaricomendoza-alaskaair closed 6 months ago

cynthiaricomendoza-alaskaair commented 6 months ago

Please verify the version of auro-input you have installed

v2.17.10

Please describe the bug

  1. set a value in the auro-input component
  2. then set disabled to true on the auro-input component
  3. observe the close btn icon is visible and the value can be cleared in the disabled state

Reproducing the error on the docsite

This issue is reproducible on the Auro docsite

Expected behavior

when the auro-input is disabled and there is a value, i would expect the close btn icon to be hidden.

What browsers are you seeing the problem on?

Firefox, Chrome, Safari

Additional context

here is a screenshot of the behavior in our reservation look up component. the auro-input component is outlined in red.

Screenshot 2024-05-03 at 14 01 11

I am able to inspect a auro-input component on the auro docsite and add disabled to the auro-input component with a value in devtools. here is a screen recording of how i was able to reproduce. https://github.com/AlaskaAirlines/auro-input/assets/116121736/486fffc3-d066-4729-bfff-428306c49aa8

Patrick-Daly-AA commented 6 months ago

Reviewing with UX Design before implementing a fix.

leeejune commented 6 months ago

That makes sense. The clear button should also be disabled OR not be visible when the input is disabled. Either solution would work.