AlaskaAirlines / auro-input

Custom HTML element for inputting string data in forms
https://auro.alaskaair.com/components/auro/input
Apache License 2.0
2 stars 4 forks source link

onDark theme doesn't change color of the X clear value icon #92

Closed jason-capsule42 closed 2 months ago

jason-capsule42 commented 2 years ago

Describe the bug

To Reproduce

Steps to reproduce the behavior:

  1. Use <auro-input onDark />
  2. Enter a value in the input
  3. Examine the X clear icon

Expected behavior

The icon should not be black, it should be --auro-color-icon-disabled-on-dark

blackfalcon commented 2 years ago

@jason-capsule42 auro-input doesn't support ondark?

https://auro.alaskaair.com/components/auro/input/api

blackfalcon commented 2 years ago

auro-input onDark should be removed from the element with v3.0 and then we can look to adding better dark mode support.

Patrick-Daly-AA commented 2 months ago

Fixed in Beta with our theming related work.