AlaskaAirlines / auro-loader

A custom element for the purpose of illustrating animated loaders
https://auro.alaskaair.com/components/auro/loader
Apache License 2.0
0 stars 1 forks source link

Beta color theming fixes #37

Closed jordanjones243 closed 2 months ago

jordanjones243 commented 2 months ago

Alaska Airlines Pull Request

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Resolves: #32, #34

Summary:

Please summarize the scope of the changes you have submitted, what the intent of the work is and anything that describes the before/after state of the project.

Type of change:

Please delete options that are not relevant.

Checklist:

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!
-- Auro Design System Team

Summary by Sourcery

Enhance the component registration process by using a runtime utility for tag renaming and update semantic tokens for accurate color theming. Remove outdated Beta release information from the CHANGELOG and update documentation to include theme support details.

Enhancements:

Documentation:

sourcery-ai[bot] commented 2 months ago

Reviewer's Guide by Sourcery

This pull request focuses on improving color theming, updating component registration, and cleaning up documentation for the auro-loader component. The changes include updating semantic tokens for correct color values, refactoring the custom component registration process, and removing beta release information from the changelog.

File-Level Changes

Change Details Files
Updated semantic tokens for color values
  • Changed color token for onlight variant to use --ds-color-utility-navy-default
  • Updated ondark variant to use --ds-color-utility-cyan-inverse
  • Modified white variant to use --ds-color-utility-neutral-inverse
src/color.scss
Refactored custom component registration process
  • Removed registerComponent function from index.js
  • Added RuntimeUtils import and usage for component registration
  • Updated demo and documentation to reflect new registration method
index.js
demo/index.md
docs/partials/index.md
demo/index.html
Improved component initialization and custom tag handling
  • Added AuroLibraryRuntimeUtils for handling component tag renaming
  • Removed handleCustomTagName method and replaced with runtimeUtils.handleComponentTagRename
src/auro-loader.js
Updated documentation and added theme support information
  • Added theme support section in API documentation
  • Removed CSS Custom Property fallbacks section from README
  • Updated demo and usage examples
demo/api.md
README.md
docs/partials/api.md
Cleaned up CHANGELOG
  • Removed beta release information from CHANGELOG.md
CHANGELOG.md

Tips - Trigger a new Sourcery review by commenting `@sourcery-ai review` on the pull request. - Continue your discussion with Sourcery by replying directly to review comments. - You can change your review settings at any time by accessing your [dashboard](https://app.sourcery.ai): - Enable or disable the Sourcery-generated pull request summary or reviewer's guide; - Change the review language; - You can always [contact us](mailto:support@sourcery.ai) if you have any questions or feedback.
blackfalcon commented 2 months ago

:tada: This PR is included in version 2.1.0-beta.3 :tada:

The release is available on:

Your semantic-release bot :package::rocket: