AlaskaAirlines / auro-loader

A custom element for the purpose of illustrating animated loaders
https://auro.alaskaair.com/components/auro/loader
Apache License 2.0
0 stars 1 forks source link

fix: update markdown partial pathing to consume new auro lib #48 #49

Closed sun-mota closed 1 week ago

sun-mota commented 3 weeks ago

Alaska Airlines Pull Request

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Resolves: #48

Summary:

Please summarize the scope of the changes you have submitted, what the intent of the work is and anything that describes the before/after state of the project.

Type of change:

Please delete options that are not relevant.

Checklist:

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!
-- Auro Design System Team

Summary by Sourcery

Bug Fixes:

Summary by Sourcery

Bug Fixes:

Summary by Sourcery

Bug Fixes:

Summary by Sourcery

Update markdown partial paths to reflect the new auro library structure and enhance the build process by adding the nodeResolve plugin to the Rollup configuration.

Bug Fixes:

Enhancements:

sourcery-ai[bot] commented 3 weeks ago

Reviewer's Guide by Sourcery

This PR updates the file path references in markdown files to align with the new auro library structure. The changes primarily involve modifying relative path references in various markdown and configuration files to use the updated directory structure. Additionally, the PR updates the auro-library dependency to version ^3.0.1 and adds nodeResolve plugin to rollup configurations.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Updated markdown file path references to align with new directory structure
  • Changed relative path references from './../../' to '../' in multiple files
  • Updated paths from './../' to '../docs/' for better organization
  • Modified content source paths in AURO-GENERATED-CONTENT blocks
demo/api.md
demo/index.md
docs/partials/api.md
docs/partials/index.md
README.md
Updated build configuration and dependencies
  • Added nodeResolve plugin to rollup configurations for both index and api examples
  • Updated @aurodesignsystem/auro-library dependency from ~2.8 to ^3.0.1
  • Updated WC-Generator template reference path in README.md
rollup.config.mjs
package.json
README.md

Tips and commands #### Interacting with Sourcery - **Trigger a new review:** Comment `@sourcery-ai review` on the pull request. - **Continue discussions:** Reply directly to Sourcery's review comments. - **Generate a GitHub issue from a review comment:** Ask Sourcery to create an issue from a review comment by replying to it. - **Generate a pull request title:** Write `@sourcery-ai` anywhere in the pull request title to generate a title at any time. - **Generate a pull request summary:** Write `@sourcery-ai summary` anywhere in the pull request body to generate a PR summary at any time. You can also use this command to specify where the summary should be inserted. #### Customizing Your Experience Access your [dashboard](https://app.sourcery.ai) to: - Enable or disable review features such as the Sourcery-generated pull request summary, the reviewer's guide, and others. - Change the review language. - Add, remove or edit custom review instructions. - Adjust other review settings. #### Getting Help - [Contact our support team](mailto:support@sourcery.ai) for questions or feedback. - Visit our [documentation](https://docs.sourcery.ai) for detailed guides and information. - Keep in touch with the Sourcery team by following us on [X/Twitter](https://x.com/SourceryAI), [LinkedIn](https://www.linkedin.com/company/sourcery-ai/) or [GitHub](https://github.com/sourcery-ai).
chrisfalaska commented 2 weeks ago

When I pulled the branch locally and ran dev, I noticed icons appeared under "Recommended Use and Version Control":

Image

However, they do not appear on the DocSite:

Image

I just wanted to confirm if this was intentional?

sun-mota commented 2 weeks ago

When I pulled the branch locally and ran dev, I noticed icons appeared under "Recommended Use and Version Control":

Image

However, they do not appear on the DocSite:

Image

I just wanted to confirm if this was intentional?

docSite is the one that has a bug ;)

blackfalcon commented 1 week ago

:tada: This PR is included in version 3.1.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket: