Open blackfalcon opened 1 month ago
Please replace gray-400
with gray-600
for the lock up component. This is the closest current color to the old gray-400
.
@leeejune having tested this, I would recommend using the var(--ds-color-base-gray-700)
token. The Gray 600 has a hex of 7E7E7E
that fails for small type.
Setting issues as BLOCKED until the color choice question can be resolved.
@leeejune having tested this, I would recommend using the
var(--ds-color-base-gray-700)
token. The Gray 600 has a hex of7E7E7E
that fails for small type.
This should work. Thanks for catching that.
Please verify the version of auro-lockup you have installed
@latest
Please describe the bug
When upgrading to @aurodesignsystem/design-tokens v4.7 and running a build of the component, you will get the following build error.
With the updated tokens, the currently used token of
--ds-color-brand-gray-400
with the value of#adadad
has a2.24:1
color ratio which failed the accessibility requirement.The previous value was
#767676
had a ratio of4.54:1
Reproducing the error
This issue cannot be reproduced on the Auro docsite
Expected behavior
The design of the element should be void of color accessibility issues. be
What browsers are you seeing the problem on?
No response
Additional context
It is undetermined whether to update the token or the token assigned to the text in this element. What is also unknown is the impact across all the properties currently using the
--ds-color-brand-gray-400
token.A search revealed that this value is being used within the Seats UI. https://github.com/Alaska-ECommerce/seats-ui-components/blob/40b855519bbadfbde8c6bf970d72bf39ecb52a5e/src/Tab/tab.styles.ts#L5
Exit criteria
This issue can be closed once it is able to build with the updated design tokens successfully.