jordanjones243 commented 4 days ago

Alaska Airlines Pull Request

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Resolves: # (issue, if applicable)

Summary:

Please summarize the scope of the changes you have submitted, what the intent of the work is and anything that describes the before/after state of the project.

Type of change:

Please delete options that are not relevant.

[x] New capability
[x] Revision of an existing capability
[ ] Infrastructure change (automation, etc.)
[ ] Other (please elaborate)

Checklist:

[x] My update follows the CONTRIBUTING guidelines of this project
[x] I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!
-- Auro Design System Team

Summary by Sourcery

Fix color token references and refactor component registration to use RuntimeUtils for improved consistency and maintainability. Update documentation to reflect these changes.

Bug Fixes:

Correct color token references for subtitle and title colors in SCSS files to use appropriate tier 2 tokens.

Enhancements:

Refactor component registration to use RuntimeUtils for registering custom elements, improving consistency and maintainability.

Documentation:

Update documentation to reflect changes in component registration method using RuntimeUtils.

sourcery-ai[bot] commented 4 days ago

Reviewer's Guide by Sourcery

This pull request updates the auro-lockup component, focusing on improving color token usage, updating the component registration process, and enhancing the runtime utilities. The changes aim to standardize the component's implementation and improve its integration with the Auro Design System.

Updated class diagram for AuroLockup component

classDiagram
    class AuroLockup {
        +String path
        +Boolean standard
        +Boolean oneworld
        -AuroLibraryRuntimeUtils runtimeUtils
        +firstUpdated()
    }
    class AuroLibraryRuntimeUtils
    AuroLockup --> AuroLibraryRuntimeUtils

File-Level Changes

Change	Details	Files
Updated color token usage for better consistency and accessibility	Changed subtitle color from base-gray-700 to text-tertiary-default Changed title color from brand-breeze-400 to text-info-default Added a comment about revisiting the Alaska logo color	`demo/api.md` `src/tokens.scss`
Refactored component registration process	Removed custom registerComponent function Implemented RuntimeUtils.default.prototype.registerComponent for component registration Updated import statements to use RuntimeUtils from auro-library	`index.js` `demo/index.md` `docs/partials/index.md` `demo/index.html`
Enhanced runtime utilities in the AuroLockup class	Added a private runtimeUtils property Implemented firstUpdated lifecycle method to handle component tag renaming	`src/auro-lockup.js`
Updated dependency versions in README.md	Updated design-tokens version to 4.10.0 Updated webcorestylesheets version to 6.0.0	`README.md`

Tips and commands

#### Interacting with Sourcery - **Trigger a new review:** Comment `@sourcery-ai review` on the pull request. - **Continue discussions:** Reply directly to Sourcery's review comments. - **Generate a GitHub issue from a review comment:** Ask Sourcery to create an issue from a review comment by replying to it. #### Customizing Your Experience Access your [dashboard](https://app.sourcery.ai) to: - Enable or disable review features such as the Sourcery-generated pull request summary, the reviewer's guide, and others. - Change the review language. - Add, remove or edit custom review instructions. - Adjust other review settings. #### Getting Help - [Contact our support team](mailto:support@sourcery.ai) for questions or feedback. - Visit our [documentation](https://docs.sourcery.ai) for detailed guides and information. - Keep in touch with the Sourcery team by following us on [X/Twitter](https://x.com/SourceryAI), [LinkedIn](https://www.linkedin.com/company/sourcery-ai/) or [GitHub](https://github.com/sourcery-ai).

blackfalcon commented 4 days ago

:tada: This PR is included in version 4.0.0-beta.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

AlaskaAirlines / auro-lockup

Fix color tokens #31