AlaskaAirlines / auro-lockup

Custom element that ....
https://auro.alaskaair.com/components/auro/lockup
Apache License 2.0
0 stars 0 forks source link

Update ondark styles #32

Closed jordanjones243 closed 4 days ago

jordanjones243 commented 4 days ago

Alaska Airlines Pull Request

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Resolves: # (issue, if applicable)

Summary:

Please summarize the scope of the changes you have submitted, what the intent of the work is and anything that describes the before/after state of the project.

Type of change:

Please delete options that are not relevant.

Checklist:

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!
-- Auro Design System Team

Summary by Sourcery

Revise the onDark styles to improve color contrast by updating subtitle and title color variables, and clean up comments in the documentation.

Enhancements:

Documentation:

sourcery-ai[bot] commented 4 days ago

Reviewer's Guide by Sourcery

This pull request updates the styles for the 'onDark' variant of a component, specifically focusing on color variables for the Alaska Airlines lockup. The changes involve updating color tokens for better consistency and removing outdated comments.

Class diagram for updated color variables

classDiagram
    class OnDarkStyles {
        --ds-auro-lockup-alaska-logo-color: var(--ds-color-icon-primary-inverse)
        --ds-auro-lockup-subtitle-color: var(--ds-color-text-tertiary-inverse)
        --ds-auro-lockup-title-color: var(--ds-color-text-subtle-inverse)
    }

    class DefaultStyles {
        --ds-auro-lockup-alaska-logo-color: var(--ds-color-brand-lounge)
        --ds-auro-lockup-divider-color: var(--ds-color-border-divider-default)
        --ds-auro-lockup-subtitle-color: var(--ds-color-text-tertiary-default)
        --ds-auro-lockup-title-color: var(--ds-color-text-info-default)
    }

    OnDarkStyles --> DefaultStyles : inherits

File-Level Changes

Change Details Files
Update color variables for 'onDark' variant
  • Remove '--ds-auro-lockup-divider-color' variable
  • Update '--ds-auro-lockup-subtitle-color' to use '--ds-color-text-tertiary-inverse'
  • Update '--ds-auro-lockup-title-color' to use '--ds-color-text-subtle-inverse'
  • Remove comments about needing tier 2 tokens
src/color.scss
Remove outdated comment for Alaska logo color
  • Delete comment suggesting the need to revisit the Alaska logo color
demo/api.md
src/tokens.scss

Tips and commands #### Interacting with Sourcery - **Trigger a new review:** Comment `@sourcery-ai review` on the pull request. - **Continue discussions:** Reply directly to Sourcery's review comments. - **Generate a GitHub issue from a review comment:** Ask Sourcery to create an issue from a review comment by replying to it. #### Customizing Your Experience Access your [dashboard](https://app.sourcery.ai) to: - Enable or disable review features such as the Sourcery-generated pull request summary, the reviewer's guide, and others. - Change the review language. - Add, remove or edit custom review instructions. - Adjust other review settings. #### Getting Help - [Contact our support team](mailto:support@sourcery.ai) for questions or feedback. - Visit our [documentation](https://docs.sourcery.ai) for detailed guides and information. - Keep in touch with the Sourcery team by following us on [X/Twitter](https://x.com/SourceryAI), [LinkedIn](https://www.linkedin.com/company/sourcery-ai/) or [GitHub](https://github.com/sourcery-ai).
blackfalcon commented 4 days ago

:tada: This PR is included in version 4.0.0-beta.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket: