search

AlaskaAirlines / auro-lockup

Custom element that ....
https://auro.alaskaair.com/components/auro/lockup
Apache License 2.0
0 stars 0 forks source link

Update onDark divider color #34

Closed jordanjones243 closed 3 days ago

jordanjones243 commented 3 days ago

Alaska Airlines Pull Request

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Resolves: # (issue, if applicable)

Summary:

Please summarize the scope of the changes you have submitted, what the intent of the work is and anything that describes the before/after state of the project.

Type of change:

Please delete options that are not relevant.

Checklist:

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!
-- Auro Design System Team

Summary by Sourcery

Enhance the onDark theme by introducing a new CSS variable for the divider color to ensure consistent styling across components.

Enhancements:

sourcery-ai[bot] commented 3 days ago

Reviewer's Guide by Sourcery

This pull request updates the color of the divider in the Auro Design System's lockup component when used on dark backgrounds. The change adds a new CSS custom property for the divider color in the onDark host selector.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Added a new CSS custom property for the divider color in dark mode
  • Introduced --ds-auro-lockup-divider-color custom property
  • Set the value to var(--ds-color-border-divider-inverse) with a fallback to #{$ds-color-border-divider-inverse}
 src/color.scss
Tips and commands #### Interacting with Sourcery - **Trigger a new review:** Comment `@sourcery-ai review` on the pull request. - **Continue discussions:** Reply directly to Sourcery's review comments. - **Generate a GitHub issue from a review comment:** Ask Sourcery to create an issue from a review comment by replying to it. - **Generate a pull request title:** Write `@sourcery-ai` anywhere in the pull request title to generate a title at any time. #### Customizing Your Experience Access your [dashboard](https://app.sourcery.ai) to: - Enable or disable review features such as the Sourcery-generated pull request summary, the reviewer's guide, and others. - Change the review language. - Add, remove or edit custom review instructions. - Adjust other review settings. #### Getting Help - [Contact our support team](mailto:support@sourcery.ai) for questions or feedback. - Visit our [documentation](https://docs.sourcery.ai) for detailed guides and information. - Keep in touch with the Sourcery team by following us on [X/Twitter](https://x.com/SourceryAI), [LinkedIn](https://www.linkedin.com/company/sourcery-ai/) or [GitHub](https://github.com/sourcery-ai).
blackfalcon commented 3 days ago

:tada: This PR is included in version 4.0.0-beta.3 :tada:

The release is available on:

Your semantic-release bot :package::rocket: