AlaskaAirlines / auro-radio

Custom input element of type radio generally used in radio groups—collections of radio buttons describing a set of related options
https://auro.alaskaair.com/components/auro/radio
Apache License 2.0
1 stars 5 forks source link

Update design of states #98 #100

Closed leeejune closed 1 year ago

leeejune commented 1 year ago

Alaska Airlines Pull Request

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Resolves: #98

Summary:

Please summarize the scope of the changes you have submitted, what the intent of the work is and anything that describes the before/after state of the project.

Added refactored state on radio.

Changes include:

Type of change:

Please delete options that are not relevant.

Checklist:

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!
-- Auro Design System Team

leeejune commented 1 year ago

I couldn't get husky to run the pre-commit hook. I got the same error from https://github.com/AlaskaAirlines/auro-radio/pull/99

blackfalcon commented 1 year ago

I couldn't get husky to run the pre-commit hook. I got the same error from #99

What version of Node are you using? When using Node 16, I get the following error.

husky > pre-commit (node v16.13.0)
Watching /Users/dalesande/src/auro/radio and all sub-directories not excluded by your .gitignore. Will not monitor dotfiles.
Found & ignored ./node_modules ; is listed in .gitignore
Found & ignored ./coverage/Chrome Headless 102.0.5005.61 (Mac OS 10.15.7)/base.css ; has ignored extension
Found & ignored ./coverage/Chrome Headless 102.0.5005.61 (Mac OS 10.15.7)/prettify.css ; has ignored extension
Found & ignored ./coverage/Chrome Headless 105.0.5195.102 (Mac OS 10.15.7)/base.css ; has ignored extension
Found & ignored ./coverage/Chrome Headless 105.0.5195.102 (Mac OS 10.15.7)/prettify.css ; has ignored extension
Found & ignored ./coverage/Chrome Headless 111.0.5563.146 (Mac OS 10.15.7)/base.css ; has ignored extension
Found & ignored ./coverage/Chrome Headless 111.0.5563.146 (Mac OS 10.15.7)/prettify.css ; has ignored extension
Found & ignored ./coverage/Chrome Headless 91.0.4472.114 (Mac OS 10.15.7)/base.css ; has ignored extension
Found & ignored ./coverage/Chrome Headless 91.0.4472.114 (Mac OS 10.15.7)/prettify.css ; has ignored extension
Found & ignored ./coverage/Chrome Headless 94.0.4606.54 (Mac OS 10.15.7)/base.css ; has ignored extension
Found & ignored ./coverage/Chrome Headless 94.0.4606.54 (Mac OS 10.15.7)/prettify.css ; has ignored extension
Found & ignored ./demo/sass/style.css ; has ignored extension
Found & ignored ./src/auro-radio-group.css ; has ignored extension
Found & ignored ./src/auro-radio.css ; has ignored extension

Starting: test
node:internal/modules/cjs/loader:936
  throw err;
  ^

I have to use Node 12 for this to work due to a really old version of Huskey that we need to update. Do this.

 $ nvm use 12
 $ npm ci