search

AlaskaAirlines / auro-radio

Custom input element of type radio generally used in radio groups—collections of radio buttons describing a set of related options
https://auro.alaskaair.com/components/auro/radio
Apache License 2.0
1 stars 6 forks source link

Remove spacing below radio group #103

Closed leeejune closed 1 year ago

leeejune commented 1 year ago

Describe the bug

There is extra spacing below radio group.

To Reproduce

Steps to reproduce the behavior:

  1. Go to https://auro.alaskaair.com/components/auro/radio#:~:text=Radio-,button,-group
  2. See extra spacing

Expected behavior

There should be no extra spacing below radio group.

Screenshots

Screenshot 2023-04-24 at 1 05 12 PM

blackfalcon commented 1 year ago

This spacing was intentional so that the items can be stacked without having to add in that space.

https://github.com/AlaskaAirlines/auro-radio/blob/6ef3373657964230237bc829dca70a6efce6205f/src/auro-radio-group.scss#L13-L16

This is not a bug and we cannot simply remove this as this will cause UI errors wherever in use. Reclassing this as a feature where we could use CSS Parts to allow an public API options for users to change this value.

ashleybiermannalaska commented 1 year ago

I'm willing to look into a fix for this. Talked with Brandon Shields for approach. Planning to use CSS parts to open an option in shadow dom to allow for that spacing default to be adjusted.

blackfalcon commented 1 year ago

@ashleybiermannalaska the issue is assigned to you to work on during this sprint. Please reach out to the team for any questions.

Thanks! Auro

jason-capsule42 commented 1 year ago

@blackfalcon I see you moved this to Review Needed but the PR is still in draft mode? Are you just looking for a sort of preview review?