AlaskaAirlines / auro-radio

Custom input element of type radio generally used in radio groups—collections of radio buttons describing a set of related options
https://auro.alaskaair.com/components/auro/radio
Apache License 2.0
1 stars 5 forks source link

fix(disabled ui): loop safe check when disabled #105 #106

Closed jesussilverioea closed 1 year ago

jesussilverioea commented 1 year ago

Alaska Airlines Pull Request

This is a safe check so we do not enter an infinite loop when a radio group is disabled and we push key "up"

this is the current state when we push arrow "up" on a disabled auro-radio-group:

image

Fixes: #105

Summary:

This changes affect the disabled button and do not disrupt current functionality.

Type of change:

Please delete options that are not relevant.

Checklist:

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!
-- Auro Design System Team

AuroDesignSystem commented 1 year ago

:tada: This PR is included in version 1.6.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket: