AlaskaAirlines / auro-radio

Custom input element of type radio generally used in radio groups—collections of radio buttons describing a set of related options
https://auro.alaskaair.com/components/auro/radio
Apache License 2.0
1 stars 6 forks source link

[Accessibility] Disabled radio-group should not be focusable #47 #109

Closed fajar-apri-alaska closed 1 year ago

fajar-apri-alaska commented 1 year ago

Alaska Airlines Pull Request

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes: #47

Summary:

adding a condition inside resetRadio function handler when setting the tabIndex

Type of change:

Please delete options that are not relevant.

Checklist:

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!
-- Auro Design System Team

blackfalcon commented 1 year ago

Please rebase off of the latest release. https://auro.alaskaair.com/contributing/upstream

fajar-apri-alaska commented 1 year ago

Hi @blackfalcon, I have rebased off upstream master, please tell me if it is good. Thanks~

blackfalcon commented 1 year ago

Will be adding this code update to the following PR

fajar-apri-alaska commented 1 year ago

Will be adding this code update to the following PR

OK, I will also put above PR in my watch list.

fajar-apri-alaska commented 1 year ago

I am going to close this PR since changes already included in #111. Thanks~