AlaskaAirlines / auro-select

Combo custom element containing pre-defined trigger options with menu in the dropdown panel
https://auro.alaskaair.com/components/auro/select
Apache License 2.0
2 stars 0 forks source link

disabled styles do not match other disabled auro components #185

Closed cynthiaricomendoza-alaskaair closed 3 months ago

cynthiaricomendoza-alaskaair commented 4 months ago

Describe the bug

when the auro-select component is disabled, it has an opacity set to 0.7 causing it to not appear the same as auro-input and auro-combobox when they are also disabled.

To Reproduce

Steps to reproduce the behavior:

  1. Go to https://auro.alaskaair.com/components/auro/select and scroll to the disabled example
  2. Inspect the disabled auro-select component
  3. Observe host([disabled]) has opacity set to 0.7
  4. Go to https://auro.alaskaair.com/components/auro/input and scroll to the disabled example
  5. Inspect the disabled auro-input component
  6. Observe host([disabled]) does not have an opacity set

Expected behavior

If auro components support the disabled property and they are set to disabled, I would like to see the styles be consistent across all components.

Screenshots

Here is an example of what the disabled auro-combobox, auro-select, and auro-input look like beside one another.

Screenshot 2024-04-24 at 16 40 45

Desktop (please complete the following information):

Smartphone (please complete the following information):

Additional context

When I uncheck the opacity style in the dev tools, auro-select now has the same disabled styling as auro-combobox and auro-input:

Screenshot 2024-04-24 at 17 17 45
Patrick-Daly-AA commented 4 months ago

This will be fixed as part of our larger theming and token overhaul we are in progress on.

cynthiaricomendoza-alaskaair commented 4 months ago

thanks for the update @Patrick-Daly-AA! do you have an estimate on when that work will be complete?

Patrick-Daly-AA commented 4 months ago

@cynthiaricomendoza-alaskaair , We're expecting theming work for colors to be completed in early June at the latest. If you need a fix sooner, let us know and we can either do a one-off fix for this, or can ensure that we cover this early in the theming release(s).