jason-capsule42 commented 2 weeks ago

Alaska Airlines Pull Request

Type of change:

Please delete options that are not relevant.

[ ] New capability
[x] Revision of an existing capability
[ ] Infrastructure change (automation, etc.)
[ ] Other (please elaborate)

Checklist:

[x] My update follows the CONTRIBUTING guidelines of this project
[x] I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!
-- Auro Design System Team

Summary by Sourcery

Fix the SSR issue in auro-table by replacing the .map function with .forEach and update tests to reflect these changes.

Bug Fixes:

Fix the issue with the .map function in server-side rendering (SSR) by replacing it with .forEach in the auro-table component.

Tests:

Update tests for auro-table to correctly select table columns and rows, ensuring compatibility with the new implementation.

sourcery-ai[bot] commented 2 weeks ago

Reviewer's Guide by Sourcery

This PR fixes a server-side rendering (SSR) issue by replacing the .map function with .forEach in the table header rendering logic and adjusts the test suite's column selection approach to properly target table cells.

Updated class diagram for AuroTable component

classDiagram
    class AuroTable {
        - columnHeaders
        + renderTableHeader()
    }
    note for AuroTable "Replaced .map with .forEach in renderTableHeader method"

File-Level Changes

Change	Details	Files
Fixed SSR compatibility issue in table header rendering	Replaced Array.map() with Array.forEach() in table header template rendering Modified header cell rendering implementation to ensure proper SSR support	`src/auro-table.js`
Updated test suite column selection logic	Changed column selector from 'th' to 'td' elements Added row selection before getting columns Updated column selection to target specific row index	`test/auro-table.test.js`

Tips and commands

#### Interacting with Sourcery - **Trigger a new review:** Comment `@sourcery-ai review` on the pull request. - **Continue discussions:** Reply directly to Sourcery's review comments. - **Generate a GitHub issue from a review comment:** Ask Sourcery to create an issue from a review comment by replying to it. - **Generate a pull request title:** Write `@sourcery-ai` anywhere in the pull request title to generate a title at any time. - **Generate a pull request summary:** Write `@sourcery-ai summary` anywhere in the pull request body to generate a PR summary at any time. You can also use this command to specify where the summary should be inserted. #### Customizing Your Experience Access your [dashboard](https://app.sourcery.ai) to: - Enable or disable review features such as the Sourcery-generated pull request summary, the reviewer's guide, and others. - Change the review language. - Add, remove or edit custom review instructions. - Adjust other review settings. #### Getting Help - [Contact our support team](mailto:support@sourcery.ai) for questions or feedback. - Visit our [documentation](https://docs.sourcery.ai) for detailed guides and information. - Keep in touch with the Sourcery team by following us on [X/Twitter](https://x.com/SourceryAI), [LinkedIn](https://www.linkedin.com/company/sourcery-ai/) or [GitHub](https://github.com/sourcery-ai).

blackfalcon commented 2 weeks ago

:tada: This PR is included in version 3.1.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

AlaskaAirlines / auro-table

fix: remove .map function that doesn't work in SSR support #94 #95