Alastors / ThaumicBoots

A new addon for Thaumcraft 4 focused on the application in the combination of magicks in the creation of boots
MIT License
7 stars 7 forks source link

Toggle grief effect #30

Open Derghust opened 8 months ago

Alastors commented 8 months ago

Lmfao, don't add the change log file, I'll just update the readme

Alastors commented 8 months ago

Also the speed bonus while flying is intentional, some boots don't get it, this is based off the attributes of the base boots

Derghust commented 8 months ago

Also the speed bonus while flying is intentional, some boots don't get it, this is based off the attributes of the base boots

So do you suggest creating new boots with better flying boosts or trying to implement gravisuit dependency and deobfuscate it (it has no repo either sources and LICENSE, dependency example from another project https://github.com/GTNewHorizons/Gravitation-Suite-Neo/blob/master/dependencies.gradle#L5) for checking fly status? because advanced jetpack and advanced nano suit jetpack are kinda useless with those boots and even worse (same speed as vanilla, possible due: is not player.capabilities.isFlying with that equipment)?

Derghust commented 8 months ago

Lmfao, don't add the change log file, I'll just update the readme

OK, Removed

Alastors commented 8 months ago

Also the speed bonus while flying is intentional, some boots don't get it, this is based off the attributes of the base boots

So do you suggest creating new boots with better flying boosts or trying to implement gravisuit dependency and deobfuscate it (it has no repo either sources and LICENSE, dependency example from another project https://github.com/GTNewHorizons/Gravitation-Suite-Neo/blob/master/dependencies.gradle#L5) for checking fly status? because advanced jetpack and advanced nano suit jetpack are kinda useless with those boots and even worse (same speed as vanilla, possible due: is not player.capabilities.isFlying with that equipment)?

could you clarify exactly which boots you are trying to fix this for? I know what it looks like in the code, but

Derghust commented 8 months ago

Also the speed bonus while flying is intentional, some boots don't get it, this is based off the attributes of the base boots

So do you suggest creating new boots with better flying boosts or trying to implement gravisuit dependency and deobfuscate it (it has no repo either sources and LICENSE, dependency example from another project https://github.com/GTNewHorizons/Gravitation-Suite-Neo/blob/master/dependencies.gradle#L5) for checking fly status? because advanced jetpack and advanced nano suit jetpack are kinda useless with those boots and even worse (same speed as vanilla, possible due: is not player.capabilities.isFlying with that equipment)?

could you clarify exactly which boots you are trying to fix this for? I know what it looks like in the code, but

All new electric boots. Ensure all new electric boots are compatible with the gravitation suits mod, specifically Advanced NanoChestPlate and Advanced electric jetpack.

Right now, I have "Fixed" only electric void walker boots with speed boost on the non-ground events, but what I would suggest for all electric boots to implement flying boost on non-ground events or implement detection when a player is flying with Advanced NanoChestPlate or with Advanced electric jetpack.