search

Albacore / albacore

Albacore is a professional quality suite of Rake tasks for building .NET or Mono based systems.
www.albacorebuild.net
221 stars 64 forks source link

[build] Writes unnecessary INFO message when looking for msbuild (windows) #153

Closed joelwilson closed 9 years ago

joelwilson commented 9 years ago

When executing the build task, Albacore calls CrossPlatformCmd.which a few times in an effort to find the correct build tool. See build.rb:44

On Windows 7, the non-matching calls results in where being called a few times. When where can't find the command, it returns an informational message, which Albacore does not suppress, revealing some of the internal goings-on of Albacore to the user. In my case, there were four messages:

INFO: Could not find files for the given pattern(s).
INFO: Could not find files for the given pattern(s).
INFO: Could not find files for the given pattern(s).
INFO: Could not find files for the given pattern(s).

The nanoc repo has a pull request (298) containing a solution to this problem. Simply use command 2> nul to redirect error messages on Windows. That would require some changes to cross_platform_cmd.rb:186.

haf commented 9 years ago

Go ahead, I'll merge the PR ;)

haf commented 9 years ago

I've pushed a new albacore release.