Albacore / albacore

Albacore is a professional quality suite of Rake tasks for building .NET or Mono based systems.
www.albacorebuild.net
221 stars 64 forks source link

Simple way of using nuget gem #182

Closed wallymathieu closed 9 years ago

wallymathieu commented 9 years ago

Since the nuget gem contains the exe, we can use that to simplify scripts when you have the gem installed.

haf commented 9 years ago

This is a nice way of doing it. Could you please write a unit test that calling that flag sets the correct path of the nuget?

haf commented 9 years ago

PRs don't notify of pushed commits, so I didn't know you had fixed this!

Is this ready to be merged? =)

wallymathieu commented 9 years ago

I was thinking if I needed to add tests of the usage, what do you think?

haf commented 9 years ago

Yes, a test of the usage would be welcome, too. There should already be helpers and tests that test other aspects of the usage. If you have any questions; just ask!

wallymathieu commented 9 years ago

How do you like the look of these tests?

haf commented 9 years ago

I like the look of them :+1: , commented on the failing one.

wallymathieu commented 9 years ago

There, looks like it works in 1.9.3 now.

haf commented 9 years ago

@wallymathieu Thank you for your contribution! The final step is to document your switch in the wiki. Could you please do that, as well?

wallymathieu commented 9 years ago

I've added documentation in the wiki for both the nuget restore and pack sections.

haf commented 9 years ago

Released as v2.5.4!