Closed antonialvarez closed 8 years ago
I see. Perhaps you'd PR that change? THanks.
Since many methods in dsl.rb
use the same task creation pattern, should they all be fixed in the same way?
And yes, I can create a pull request.
Yes, that's the way to go! =)
Deal! :)
@haf, I also need this fix, noticed @antonialvarez's build failed, forked, and attempted to make the same fix. However, the travis build also failed for me. I made another branch with just a change to allow branch builds (and removing your email)--it, too, fails in travis. Can you rerun master in travis to make sure it still works? Otherwise, any help would be appreciated.
Restarted!
@haf, thank you! The build worked fine. The main difference I see is that the Albacore repo runs on travis' legacy infrastructure while mine runs on their "new platform for Precise builds." I will try to see if their support can help.
Strange. But when I test locally it's also passing. Also, there are no sudo
calls or other strange things going on, so I can't spot why it would fail off the bat.
@haf, travis support pointed out that the installed version of bundler is old so I've submitted PR #195 to pre-install it.
Released v2.5.13 that would seem to be able to do this.
Given this sample task:
then calling
rake unit_tests[custompath]
does not populate theargs
variable in the block above. The root of the issue seems to be indsl.rb
in the definition oftest_runner
:the following implementation solves the issue