search

Albacore / albacore

Albacore is a professional quality suite of Rake tasks for building .NET or Mono based systems.
www.albacorebuild.net
221 stars 64 forks source link

#229 Add detection of MSBuild 15 #230

Closed dusk0r closed 7 years ago

dusk0r commented 7 years ago

MSBuild 15 is now bundled with VS2017. It doesn't use the same path or registry keys as previous versions did.

haf commented 7 years ago

Indentation is wrong.

Also, shouldn't you return nil if it's not found?

dusk0r commented 7 years ago

No, the method returns a hash of all available msbuild versions.

haf commented 7 years ago

Thank you @dusk0r !

dusk0r commented 7 years ago

@haf Oh, I just noticed that I forgot to add the 'msbuild.exe' to the path. Should I open a new pull request?

Line 26 should be: retval[15] = File.join(vs2017_dir, 'MSBuild', '15.0', 'Bin', 'msbuild.exe') unless vs2017_dir.nil?

haf commented 7 years ago

If you want it in the next version then you should.

dusk0r commented 7 years ago

Added a new pull request https://github.com/Albacore/albacore/pull/231

haf commented 7 years ago

Will go into the next release.