search

AlbaneMiron / drone-simulation

2 stars 2 forks source link

force python version to 3.7.4 #80

Closed AlbaneMiron closed 4 years ago

AlbaneMiron commented 4 years ago

@pcorpet There is a problem with the online version of the app: when "Rate of OHCA at home, which only have one witness alone" is set to 0 the simulation won't update (silent fail: it displays the results for the previous set of parameters). I cannot reproduce the error with my localhost, so I guess it is an issue due to a different Python version. I'd really appreciate your opinion on this before pushing to master: do you think it could resolve the problem?

pcorpet commented 4 years ago

I was able to reproduce locally.

Actually the bug is in the dbc.Input component (the 0 value although valid is converted to null). It was fixed by: https://github.com/facultyai/dash-bootstrap-components/commit/ce6e41c07cefe57ddca410d229b18c5438565930#diff-e878ecea00eac0e967ab531dbd386d28 and released starting at 0.8.3. I suggest we upgrade dash-bootstrap-components , at least to v0.8.3 but why not to v0.10.3?

Note that dbc v0.8.3 requires dash v1.9+, but again why not update it to the latest v1.14?

I've tried upgrading both locally and it seems to fix the bug and the rest seems to work as intended.

AlbaneMiron commented 4 years ago

Thank you for your insight, it seems to be working fine locally for me too.

I forced dash and dash-bootstrap-components versions to fix an interaction with the dash_core_components Loading component. This bug looks fixed with dash v1.14 and dash-bootstrap-components v0.10.3, so I'll merge your lastest PR and delete this one.