search

Alberplz / angular2-color-picker

Angular 2 Color Picker Directive, no dependences required.
MIT License
185 stars 82 forks source link

Fix cpWidth setting and add change detection for cpPresetColors #48

Closed sconix closed 7 years ago

sconix commented 7 years ago

Last version broke the custom width setting. This fixes that by adding slider initialization after view init when using custom value. This also adds support for cpWidth 'auto' which means that width of the trigger element is used (useful for when showing dialog on bottom and you want the width to match the trigger element).

I also added change detection and updating of preset settings since those can change after dialog has been opened for the first time.

Alberplz commented 7 years ago

Ive updated to 2.4, sconix it would be possible one pull request with all your new changes?

sconix commented 7 years ago

The PR with title: Bug fixes and AOT compatibility / support includes all my PR's including this one and some other small bug fixes from PR made by others. Just let me know if you want me to make it against some other branch or changes you have made.

sconix commented 7 years ago

I see that you just pushed changes, I will make update the AOT PR so it does not conflict.

Alberplz commented 7 years ago

That's nice thank you very much

sconix commented 7 years ago

I will close this PR since this is included in that one and I will push soon fixes for that PR.